gronod/OpenTTD
1
0
Fork 0
mirror of https://github.com/OpenTTD/OpenTTD.git synced 2025-03-06 14:27:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

(svn r18647) -Fix: [YAPP] A train inside a station was not always found when checking for trains on a reserved path.

Browse Source
This commit is contained in:
michi_cc 2009-12-27 14:37:50 +00:00
parent 182b0b5c14
commit f7025612e1
3 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/pbs.cpp
View File

@ -262,7 +262,7 @@ static Vehicle *FindTrainOnTrackEnum(Vehicle *v, void *data)
* @param train_on_res Is set to a train we might encounter * @param train_on_res Is set to a train we might encounter
* @returns The last tile of the reservation or the current train tile if no reservation present. * @returns The last tile of the reservation or the current train tile if no reservation present.
*/ */
PBSTileInfo FollowTrainReservation(const Train *v, bool *train_on_res) PBSTileInfo FollowTrainReservation(const Train *v, Vehicle **train_on_res)
{ {
assert(v->type == VEH_TRAIN); assert(v->type == VEH_TRAIN);
@ -274,7 +274,21 @@ PBSTileInfo FollowTrainReservation(const Train *v, bool *train_on_res)
FindTrainOnTrackInfo ftoti; FindTrainOnTrackInfo ftoti;
ftoti.res = FollowReservation(v->owner, GetRailTypeInfo(v->railtype)->compatible_railtypes, tile, trackdir); ftoti.res = FollowReservation(v->owner, GetRailTypeInfo(v->railtype)->compatible_railtypes, tile, trackdir);
ftoti.res.okay = IsSafeWaitingPosition(v, ftoti.res.tile, ftoti.res.trackdir, true, _settings_game.pf.forbid_90_deg); ftoti.res.okay = IsSafeWaitingPosition(v, ftoti.res.tile, ftoti.res.trackdir, true, _settings_game.pf.forbid_90_deg);
if (train_on_res != NULL) *train_on_res = HasVehicleOnPos(ftoti.res.tile, &ftoti, FindTrainOnTrackEnum); if (train_on_res != NULL) {
FindVehicleOnPos(ftoti.res.tile, &ftoti, FindTrainOnTrackEnum);
if (ftoti.best != NULL) *train_on_res = ftoti.best->First();
if (*train_on_res == NULL && IsRailStationTile(ftoti.res.tile)) {
/* The target tile is a rail station. The track follower
* has stopped on the last platform tile where we haven't
* found a train. Also check all previous platform tiles
* for a possible train. */
TileIndexDiff diff = TileOffsByDiagDir(TrackdirToExitdir(ReverseTrackdir(ftoti.res.trackdir)));
for (TileIndex st_tile = ftoti.res.tile + diff; *train_on_res == NULL && IsCompatibleTrainStationTile(st_tile, ftoti.res.tile); st_tile += diff) {
FindVehicleOnPos(st_tile, &ftoti, FindTrainOnTrackEnum);
if (ftoti.best != NULL) *train_on_res = ftoti.best->First();
}
}
}
return ftoti.res; return ftoti.res;
} }

2
src/pbs.h
View File

@ -34,7 +34,7 @@ struct PBSTileInfo {
PBSTileInfo(TileIndex _t, Trackdir _td, bool _okay) : tile(_t), trackdir(_td), okay(_okay) {} PBSTileInfo(TileIndex _t, Trackdir _td, bool _okay) : tile(_t), trackdir(_td), okay(_okay) {}
}; };
PBSTileInfo FollowTrainReservation(const Train *v, bool *train_on_res = NULL); PBSTileInfo FollowTrainReservation(const Train *v, Vehicle **train_on_res = NULL);
bool IsSafeWaitingPosition(const Train *v, TileIndex tile, Trackdir trackdir, bool include_line_end, bool forbid_90deg = false); bool IsSafeWaitingPosition(const Train *v, TileIndex tile, Trackdir trackdir, bool include_line_end, bool forbid_90deg = false);
bool IsWaitingPositionFree(const Train *v, TileIndex tile, Trackdir trackdir, bool forbid_90deg = false); bool IsWaitingPositionFree(const Train *v, TileIndex tile, Trackdir trackdir, bool forbid_90deg = false);

4
src/train_cmd.cpp
View File

@ -2872,14 +2872,14 @@ bool TryPathReserve(Train *v, bool mark_as_stuck, bool first_tile_okay)
} }
} }
bool other_train = false; Vehicle *other_train = NULL;
PBSTileInfo origin = FollowTrainReservation(v, &other_train); PBSTileInfo origin = FollowTrainReservation(v, &other_train);
/* The path we are driving on is alread blocked by some other train. /* The path we are driving on is alread blocked by some other train.
* This can only happen in certain situations when mixing path and * This can only happen in certain situations when mixing path and
* block signals or when changing tracks and/or signals. * block signals or when changing tracks and/or signals.
* Exit here as doing any further reservations will probably just * Exit here as doing any further reservations will probably just
* make matters worse. */ * make matters worse. */
if (other_train && v->tile != origin.tile) { if (other_train != NULL && other_train->index != v->index) {
if (mark_as_stuck) MarkTrainAsStuck(v); if (mark_as_stuck) MarkTrainAsStuck(v);
return false; return false;
} }