From e660860d4b36ce6870786130b1861fa8fca808b8 Mon Sep 17 00:00:00 2001 From: Nicolas Chappe <74881848+nchappe@users.noreply.github.com> Date: Thu, 23 Dec 2021 13:50:19 +0100 Subject: [PATCH] Codechange: Simplify logic of mouse loop --- src/window.cpp | 34 ++++++++++++++++------------------ 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/src/window.cpp b/src/window.cpp index 603bca151f..f1a6c8550c 100644 --- a/src/window.cpp +++ b/src/window.cpp @@ -2882,27 +2882,25 @@ static void MouseLoop(MouseClick click, int mousewheel) } } - if (vp == nullptr || (w->flags & WF_DISABLE_VP_SCROLL)) { - switch (click) { - case MC_LEFT: - case MC_DOUBLE_LEFT: - DispatchLeftClickEvent(w, x - w->left, y - w->top, click == MC_DOUBLE_LEFT ? 2 : 1); - return; + switch (click) { + case MC_LEFT: + case MC_DOUBLE_LEFT: + DispatchLeftClickEvent(w, x - w->left, y - w->top, click == MC_DOUBLE_LEFT ? 2 : 1); + return; - default: - if (!scrollwheel_scrolling || w == nullptr || w->window_class != WC_SMALLMAP) break; - /* We try to use the scrollwheel to scroll since we didn't touch any of the buttons. - * Simulate a right button click so we can get started. */ - FALLTHROUGH; + default: + if (!scrollwheel_scrolling || w == nullptr || w->window_class != WC_SMALLMAP) break; + /* We try to use the scrollwheel to scroll since we didn't touch any of the buttons. + * Simulate a right button click so we can get started. */ + FALLTHROUGH; - case MC_RIGHT: - DispatchRightClickEvent(w, x - w->left, y - w->top); - return; + case MC_RIGHT: + DispatchRightClickEvent(w, x - w->left, y - w->top); + return; - case MC_HOVER: - DispatchHoverEvent(w, x - w->left, y - w->top); - break; - } + case MC_HOVER: + DispatchHoverEvent(w, x - w->left, y - w->top); + break; } /* We're not doing anything with 2D scrolling, so reset the value. */