gronod/OpenTTD
1
0
Fork 0
mirror of https://github.com/OpenTTD/OpenTTD.git synced 2025-03-12 18:40:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Codechange: Call Widget::SetDirty/SetLowered directly. (#11417)

Browse Source 
In these instances we already have the widget to hand, so don't need to look it up by index again.
This commit is contained in:
Peter Nelson 2023-11-01 20:12:08 +00:00 committed by GitHub
parent 89480f3531
commit d3cb6e1e67
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/widgets/dropdown.cpp
View File

@ -438,9 +438,9 @@ void ShowDropDownList(Window *w, DropDownList &&list, int selected, int button,
if ((nwi->type & WWT_MASK) == NWID_BUTTON_DROPDOWN) {
nwi->disp_flags |= ND_DROPDOWN_ACTIVE;
} else {
w->LowerWidget(button);
nwi->SetLowered(true);
}
w->SetWidgetDirty(button);
nwi->SetDirty(w);
if (width != 0) {
if (_current_text_dir == TD_RTL) {

4
src/window.cpp
View File

@ -228,7 +228,7 @@ void Window::DisableAllWidgetHighlight()
if (nwid->IsHighlighted()) {
nwid->SetHighlighted(TC_INVALID);
this->SetWidgetDirty(i);
nwid->SetDirty(this);
}
}
@ -248,7 +248,7 @@ void Window::SetWidgetHighlight(byte widget_index, TextColour highlighted_colour
if (nwid == nullptr) return;
nwid->SetHighlighted(highlighted_colour);
this->SetWidgetDirty(widget_index);
nwid->SetDirty(this);
if (highlighted_colour != TC_INVALID) {
/* If we set a highlight, the window has a highlight */