Codechange: Simplify setting minimum width for game options dropdown lists. (#11474)

Height isn't necessary as drop down controls already have sufficient height, so we can use GetDropDownListDimension() to get the width.

src/settings_gui.cpp

@@ -445,17 +445,8 @@ struct GameOptionsWindow : Window {
 
 			default: {
 				int selected;
-				DropDownList list = this->BuildDropDownList(widget, &selected);
+				size->width = std::max(size->width, GetDropDownListDimension(this->BuildDropDownList(widget, &selected)).width + padding.width);
-				if (!list.empty()) {
+				break;
-					/* Find the biggest item for the default size. */
-					for (const auto &ddli : list) {
-						Dimension string_dim;
-						int width = ddli->Width();
-						string_dim.width = width + padding.width;
-						string_dim.height = ddli->Height() + padding.height;
-						*size = maxdim(*size, string_dim);
-					}
-				}
 			}
 		}
 	}