gronod/OpenTTD
1
0
Fork 0
mirror of https://github.com/OpenTTD/OpenTTD.git synced 2025-03-13 02:52:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove: [Win32] (pointer-only) stack trace in crash.log (#11211)

Browse Source 
It only contains pointers, which nobody can decipher anyway.
So instead, just report "Not supported", like other targets do
when they can't print a sane stack trace.
This commit is contained in:
Patric Stout 2023-08-20 17:08:16 +02:00 committed by GitHub
parent a5aebeb1b5
commit 8f6df242c4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/os/windows/crashlog_win.cpp
View File

@ -198,25 +198,7 @@ static void PrintModuleInfo(std::back_insert_iterator<std::string> &output_itera
/* virtual */ void CrashLogWindows::LogStacktrace(std::back_insert_iterator<std::string> &output_iterator) const /* virtual */ void CrashLogWindows::LogStacktrace(std::back_insert_iterator<std::string> &output_iterator) const
{ {
fmt::format_to(output_iterator, "Stack trace:\n"); fmt::format_to(output_iterator, "Stack trace:\n");
#ifdef _M_AMD64 fmt::format_to(output_iterator, " Not supported.\n");
uint32_t *b = (uint32_t*)ep->ContextRecord->Rsp;
#elif defined(_M_IX86)
uint32_t *b = (uint32_t*)ep->ContextRecord->Esp;
#elif defined(_M_ARM64)
uint32_t *b = (uint32_t*)ep->ContextRecord->Sp;
#endif
for (int j = 0; j != 24; j++) {
for (int i = 0; i != 8; i++) {
if (IsBadReadPtr(b, sizeof(uint32_t))) {
fmt::format_to(output_iterator, " ????????"); // OCR: WAS - , 0);
} else {
fmt::format_to(output_iterator, " {:08X}", *b);
}
b++;
}
fmt::format_to(output_iterator, "\n");
}
fmt::format_to(output_iterator, "\n");
} }
#if defined(_MSC_VER) #if defined(_MSC_VER)