From 5ac333c2cccc3cb133c8587468e565e8d86e0852 Mon Sep 17 00:00:00 2001 From: Patric Stout Date: Fri, 18 Aug 2023 13:22:00 +0200 Subject: [PATCH] Fix: [MacOS] screen looks blue-ish when using newer SDKs (#11207) The define kCGBitmapByteOrder32Host changed (around SDK 12?) into an enum, which means an old #ifndef was triggering, overwriting the value to 0. Sadly, 0 means Order16Big, causing RGBA to become GRAB, which results in strange colours. As we no longer support PPC, drop that piece of code completely. --- src/video/cocoa/cocoa_v.mm | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/video/cocoa/cocoa_v.mm b/src/video/cocoa/cocoa_v.mm index 28058bea15..f94601813f 100644 --- a/src/video/cocoa/cocoa_v.mm +++ b/src/video/cocoa/cocoa_v.mm @@ -64,13 +64,6 @@ * Read http://developer.apple.com/releasenotes/Cocoa/Objective-C++.html for more information. */ -/* On some old versions of MAC OS this may not be defined. - * Those versions generally only produce code for PPC. So it should be safe to - * set this to 0. */ -#ifndef kCGBitmapByteOrder32Host -#define kCGBitmapByteOrder32Host 0 -#endif - bool _cocoa_video_started = false; static Palette _local_palette; ///< Current palette to use for drawing.