gronod/OpenTTD
1
0
Fork 0
mirror of https://github.com/OpenTTD/OpenTTD.git synced 2025-02-08 23:34:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Codechange: Avoid copying function parameters by using const references

Browse Source
This commit is contained in:
Quipyowert2 2020-02-16 17:57:22 -08:00 committed by Niels Martin Hansen
parent 0c80ae5288
commit 4552b17691
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ai/ai_gui.cpp
View File

@ -589,7 +589,7 @@ struct AISettingsWindow : public Window {
} }
private: private:
bool IsEditableItem(const ScriptConfigItem config_item) const bool IsEditableItem(const ScriptConfigItem &config_item) const
{ {
return _game_mode == GM_MENU || ((this->slot != OWNER_DEITY) && !Company::IsValidID(this->slot)) || (config_item.flags & SCRIPTCONFIG_INGAME) != 0; return _game_mode == GM_MENU || ((this->slot != OWNER_DEITY) && !Company::IsValidID(this->slot)) || (config_item.flags & SCRIPTCONFIG_INGAME) != 0;
} }

6
src/company_cmd.cpp
View File

@ -208,7 +208,7 @@ bool CheckCompanyHasMoney(CommandCost &cost)
* @param c Company to pay the bill. * @param c Company to pay the bill.
* @param cost Money to pay. * @param cost Money to pay.
*/ */
static void SubtractMoneyFromAnyCompany(Company *c, CommandCost cost) static void SubtractMoneyFromAnyCompany(Company *c, const CommandCost &cost)
{ {
if (cost.GetCost() == 0) return; if (cost.GetCost() == 0) return;
assert(cost.GetExpensesType() != INVALID_EXPENSES); assert(cost.GetExpensesType() != INVALID_EXPENSES);
@ -237,7 +237,7 @@ static void SubtractMoneyFromAnyCompany(Company *c, CommandCost cost)
* Subtract money from the #_current_company, if the company is valid. * Subtract money from the #_current_company, if the company is valid.
* @param cost Money to pay. * @param cost Money to pay.
*/ */
void SubtractMoneyFromCompany(CommandCost cost) void SubtractMoneyFromCompany(const CommandCost &cost)
{ {
Company *c = Company::GetIfValid(_current_company); Company *c = Company::GetIfValid(_current_company);
if (c != nullptr) SubtractMoneyFromAnyCompany(c, cost); if (c != nullptr) SubtractMoneyFromAnyCompany(c, cost);
@ -248,7 +248,7 @@ void SubtractMoneyFromCompany(CommandCost cost)
* @param company Company paying the bill. * @param company Company paying the bill.
* @param cst Cost of a command. * @param cst Cost of a command.
*/ */
void SubtractMoneyFromCompanyFract(CompanyID company, CommandCost cst) void SubtractMoneyFromCompanyFract(CompanyID company, const CommandCost &cst)
{ {
Company *c = Company::Get(company); Company *c = Company::Get(company);
byte m = c->money_fraction; byte m = c->money_fraction;

4
src/company_func.h
View File

@ -25,8 +25,8 @@ void CompanyAdminBankrupt(CompanyID company_id);
void UpdateLandscapingLimits(); void UpdateLandscapingLimits();
bool CheckCompanyHasMoney(CommandCost &cost); bool CheckCompanyHasMoney(CommandCost &cost);
void SubtractMoneyFromCompany(CommandCost cost); void SubtractMoneyFromCompany(const CommandCost& cost);
void SubtractMoneyFromCompanyFract(CompanyID company, CommandCost cost); void SubtractMoneyFromCompanyFract(CompanyID company, const CommandCost& cost);
CommandCost CheckOwnership(Owner owner, TileIndex tile = 0); CommandCost CheckOwnership(Owner owner, TileIndex tile = 0);
CommandCost CheckTileOwnership(TileIndex tile); CommandCost CheckTileOwnership(TileIndex tile);