From 20f7ff8ac08ffe717098a5ba2b47db4fed477c0d Mon Sep 17 00:00:00 2001 From: Jonathan G Rennison Date: Fri, 9 Sep 2022 17:40:50 +0100 Subject: [PATCH] Codechange: Fix unnecessary string reallocation in IConsoleLine constructor --- src/console_gui.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/console_gui.cpp b/src/console_gui.cpp index dcc4cd5b35..eaef1e4efa 100644 --- a/src/console_gui.cpp +++ b/src/console_gui.cpp @@ -53,8 +53,8 @@ struct IConsoleLine { * @param buffer the data to print. * @param colour the colour of the line. */ - IConsoleLine(const std::string &buffer, TextColour colour) : - buffer(buffer), + IConsoleLine(std::string buffer, TextColour colour) : + buffer(std::move(buffer)), colour(colour), time(0) {