gronod/ICCery
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 6 Wiki Activity

fix(backend): resolve .exe binary candidates on Windows (fixes #85) #97

Merged
gronod merged 1 commits from fix/85-windows-binary-resolution into development 2026-08-25 17:14:42 +01:00
Conversation 0 Commits 1 Files Changed 1
+43 -5
gronod commented 2026-08-25 17:02:36 +01:00
Owner
Copy Link
Copy Source

Summary of Changes

  • Implemented get_binary_candidates to check both {name}.exe and {name} on Windows.
  • Updated resolve_binary to inspect .exe candidates across custom settings directory and bundled resource directories.
  • Added comprehensive unit tests in commands::tests::test_get_binary_candidates.

Fixes #85.

### Summary of Changes - Implemented `get_binary_candidates` to check both `{name}.exe` and `{name}` on Windows. - Updated `resolve_binary` to inspect `.exe` candidates across custom settings directory and bundled resource directories. - Added comprehensive unit tests in `commands::tests::test_get_binary_candidates`. Fixes #85.
gronod added the Kind/Bug
Priority
High
2
 labels 2026-08-25 17:02:36 +01:00
gronod added 1 commit 2026-08-25 17:02:37 +01:00
fix(backend): resolve .exe binary candidates on Windows (fixes #85)
Build Windows Packages / Build Windows (pull_request) Successful in 7m51s
Details
Build Linux Packages / Build Linux (pull_request) Successful in 9m46s
Details
f07c8ae238
gronod merged commit df8d37c3a7 into development 2026-08-25 17:14:42 +01:00
gronod deleted branch fix/85-windows-binary-resolution 2026-08-25 17:14:43 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels Kind/Bug
Priority
High
2
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/ICCery#97