gronod/ICCery
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 6 Wiki Activity

refactor(print): consolidate duplicate print commands and improve manifest JSON parsing #79

Merged
gronod merged 1 commits from refactor/issue-67-68-clean-print-and-manifest into development 2026-08-25 12:05:54 +01:00
Conversation 0 Commits 1 Files Changed 3
+6 -74
gronod commented 2026-08-25 11:53:20 +01:00
Owner
Copy Link
Copy Source

Summary

  • Consolidates print commands: removed deprecated legacy get_windows_printers, get_cups_printers, print_target_windows, and print_target_cups commands in favor of unified cross-platform get_printers and print_target_native (resolves #67).
  • Updates src/js/printtarg.js manifest JSON extraction to robustly parse structured JSON events without newline dependency (resolves #68).

Closes #67
Closes #68

### Summary - Consolidates print commands: removed deprecated legacy `get_windows_printers`, `get_cups_printers`, `print_target_windows`, and `print_target_cups` commands in favor of unified cross-platform `get_printers` and `print_target_native` (resolves #67). - Updates `src/js/printtarg.js` manifest JSON extraction to robustly parse structured JSON events without newline dependency (resolves #68). Closes #67 Closes #68
gronod added 1 commit 2026-08-25 11:53:21 +01:00
refactor(print): remove duplicate print commands and improve manifest JSON parsing (closes #67, closes #68)
Build Linux Packages / Build Linux (pull_request) Successful in 9m38s
Details
Build Windows Packages / Build Windows (pull_request) Successful in 7m26s
Details
fd58ad12a0
gronod merged commit c8c286b5a4 into development 2026-08-25 12:05:54 +01:00
gronod deleted branch refactor/issue-67-68-clean-print-and-manifest 2026-08-25 12:05:54 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/ICCery#79