gronod/ICCery
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 6 Wiki Activity

fix(stage3): prevent instlist device index from passing as chartread -c comm port (fixes #111) #120

Merged
gronod merged 3 commits from fix/chartread-comm-port into development 2026-08-28 18:51:27 +01:00
Conversation 0 Commits 3 Files Changed 3
+3 -2036
gronod commented 2026-08-28 18:51:22 +01:00
Owner
Copy Link
Copy Source

Resolves #111

  • Changes Stage 3 instrument dropdown default and detection entries to omit the instlist ordinal index from being passed to chartread -c.
  • Tightens the instlist regex parser in src/js/chartread.js to match known instrument tokens (i1, ColorMunki, Spyder, spectro, Display, Huey, DTP, SpectroScan, Smile, Klein) or on '<port>' clauses.
  • Updates UI copy in src/index.html from 'Instrument / Hardware Port' to 'Communication Port' and 'Auto (First available port)'.
  • Adds unit tests in src-tauri/src/commands.rs verifying empty/auto port arguments.
Resolves #111 - Changes Stage 3 instrument dropdown default and detection entries to omit the instlist ordinal index from being passed to `chartread -c`. - Tightens the `instlist` regex parser in `src/js/chartread.js` to match known instrument tokens (`i1`, `ColorMunki`, `Spyder`, `spectro`, `Display`, `Huey`, `DTP`, `SpectroScan`, `Smile`, `Klein`) or `on '<port>'` clauses. - Updates UI copy in `src/index.html` from 'Instrument / Hardware Port' to 'Communication Port' and 'Auto (First available port)'. - Adds unit tests in `src-tauri/src/commands.rs` verifying empty/auto port arguments.
gronod added 3 commits 2026-08-28 18:51:23 +01:00
fix(stage3): prevent instlist device index from passing as chartread -c comm port (fixes #111) 30473b0359
fix(stage3): update UI label for chartread comm port 4c4440d7f6
test(commands): add unit tests for build_chartread_args empty/auto port a196d7cdf8
gronod merged commit b33362e656 into development 2026-08-28 18:51:27 +01:00
gronod deleted branch fix/chartread-comm-port 2026-08-28 18:51:28 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
gronod
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gronod/ICCery#120