gronod
26d9e429a9
Build and Push Docker Image / build (push) Successful in 46s
Licence Check / Licence compatibility and copyright header verification (push) Successful in 1m21s
CI / Security audit (push) Successful in 1m37s
CI / Tests & coverage (push) Successful in 2m13s
CI / Swagger Validation & Coverage (push) Successful in 1m59s
This commit addresses code review findings and completes the test coverage plan for the new Ombi webhook functionality introduced in recent commits. Changes: - Removed obsolete tests for getOmbiLink and getOmbiSearchLink functions (replaced by getOmbiDetailsLink in commit "Fix: Generate Ombi links directly from TMDB ID") - Simplified DownloadMatcher.addOmbiMatching tests to match new synchronous implementation (no longer makes API calls, generates links from TMDB IDs) - Added comprehensive integration tests for Ombi webhook endpoints: * GET /api/ombi/webhook/status (6 tests) * POST /api/ombi/webhook/enable (4 tests) * POST /api/ombi/webhook/test (3 tests) - Added frontend state object tests for Ombi fields (7 tests) - Added skipped SSE endpoint tests with documentation (2 tests) - Added skipped frontend API/UI tests with documentation (5 tests) Code review fixes: - Fixed variable shadowing in ombi.test.js (reused outer scope variable) - Removed redundant network error test (duplicate of previous test) - Updated outdated documentation comment for skipped tests Test results: 764 passing, 15 skipped, 34 test files Skipped tests are documented with clear justifications: - SSE endpoint: requires EventSource or manual SSE handling - Frontend API functions: require complex mocking, covered by integration tests - Frontend UI functions: tightly coupled to DOM, better suited for E2E testing - GET /api/ombi/requests: requires complex arrRetrieverRegistry mocking Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>