Gandalf/sofarr
Public Access
0
0
Fork 0
Code Issues 1 Pull Requests Actions 1 Packages Projects Releases 59 Wiki Activity

BUG: Download matching and deduplication is fragile (exact title only, no season pack support) #65

New Issue
Closed
opened 2026-05-28 11:40:28 +01:00 by Gandalf · 0 comments
Gandalf commented 2026-05-28 11:40:28 +01:00
Owner
Copy Link
Copy Source

Description:

The logic that matches downloads from clients to Sonarr/Radarr/Ombi requests relies on exact title matching and has no special handling for season packs or cross-client deduplication.

Detailed Investigation Findings (release/1.7.31)

Current Implementation:

  • extractArrInfo() (used in most download clients) uses simple regex for series (S##E##) and movies (year in parentheses).
  • Matching in dashboard/history views uses exact title comparison.
  • No use of download IDs, torrent hashes, or Sonarr/Radarr queue IDs for reliable linking.
  • No deduplication when the same download appears in multiple clients or when a season pack creates multiple queue entries.

Impact:

  • Incorrect or duplicate entries in the dashboard.
  • User-specific filtering (based on Sonarr/Radarr tags) fails for season packs.
  • Compounds the season pack queue bug (#61).

Proposed Solution / Fix Plan:

  1. Improve extractArrInfo() across all clients to also capture queueId / torrent hash where available.
  2. Add a centralized matching service that prefers ID/hash matching over title.
  3. Implement deduplication in the history and active downloads views.
  4. Add special handling for season packs (group by series + season or show aggregated progress).

Cross-Dependencies:

  • Directly related to season pack handling (#61). Fixing matching will make the unpacked season pack data useful in the UI.
  • Also benefits webhook reliability (better correlation of webhook events to downloads).

Suggested Labels:
Kind/Bug, Priority: Medium, Area/Matching, Area/History

Affected Versions: All versions.

**Description:** The logic that matches downloads from clients to Sonarr/Radarr/Ombi requests relies on exact title matching and has no special handling for season packs or cross-client deduplication. ### Detailed Investigation Findings (release/1.7.31) **Current Implementation:** - `extractArrInfo()` (used in most download clients) uses simple regex for series (`S##E##`) and movies (year in parentheses). - Matching in dashboard/history views uses exact title comparison. - No use of download IDs, torrent hashes, or Sonarr/Radarr queue IDs for reliable linking. - No deduplication when the same download appears in multiple clients or when a season pack creates multiple queue entries. **Impact:** - Incorrect or duplicate entries in the dashboard. - User-specific filtering (based on Sonarr/Radarr tags) fails for season packs. - Compounds the season pack queue bug (#61). **Proposed Solution / Fix Plan:** 1. Improve `extractArrInfo()` across all clients to also capture `queueId` / torrent hash where available. 2. Add a centralized matching service that prefers ID/hash matching over title. 3. Implement deduplication in the history and active downloads views. 4. Add special handling for season packs (group by series + season or show aggregated progress). **Cross-Dependencies:** - Directly related to season pack handling (#61). Fixing matching will make the unpacked season pack data useful in the UI. - Also benefits webhook reliability (better correlation of webhook events to downloads). **Suggested Labels:** Kind/Bug, Priority: Medium, Area/Matching, Area/History **Affected Versions:** All versions.
Gandalf added the Kind/Bug
Priority
Medium
3
Area/MatchingArea/History labels 2026-05-28 11:40:28 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Docker
Docker image and container packaging
 Area/Download Clients
Download client integrations
 Area/Frontend
Client-side UI and build tooling
 Area/History
History and completed downloads views
 Area/Logging
Log streaming, file handling, and debug infrastructure
 Area/Matching
Matching and correlation logic
 Area/Proxy
Upstream service proxy routes
 Area/SSE
Server-Sent Events and real-time streaming
 Area/Webhooks
Webhook processing and reliability
 Compat/Breaking
Breaking change that won't be backward compatible
 Compat/Non-Breaking
Non-breaking compatibility change
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Area/History Area/Matching Kind/Bug
Priority
Medium
3
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Gandalf
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Gandalf/sofarr#65
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?