Gandalf/sofarr
Public Access
0
0
Fork 0
Code Issues 1 Pull Requests Actions 1 Packages Projects Releases 59 Wiki Activity

BUG: Missing Radarr link button on active movie downloads (admin feature incomplete) #59

New Issue
Closed
opened 2026-05-27 23:35:27 +01:00 by Gandalf · 1 comment
Gandalf commented 2026-05-27 23:35:27 +01:00
Owner
Copy Link
Copy Source

Summary

The Radarr deep-link button is missing from active movie downloads on the main dashboard.

Administrators who have Radarr configured do not see the Radarr icon/link next to active movie downloads (from Radarr queues, SABnzbd, qBittorrent, etc.), even though the equivalent feature works for Ombi movie requests (after the fix in v1.7.28).

Steps to Reproduce

  1. Log in as an admin user.
  2. Ensure Radarr is configured and has active downloads.
  3. Go to the main Dashboard (active downloads section).
  4. Look at any active movie download card.
  5. Expected: Radarr icon/link button visible (clickable deep link to the movie in Radarr).
  6. Actual: No Radarr icon or link appears.

Expected Behavior

Active movie downloads should display a clickable Radarr icon (similar to how Ombi movie requests now show it after the recent fix) that takes the admin directly to the movie in Radarr.

Actual Behavior

  • No Radarr link button appears on active movie download cards.
  • The button works correctly on Ombi movie requests (thanks to the v1.7.28 fix).
  • Sonarr links are also missing on active TV downloads (same root cause).

Root Cause Analysis

Confirmed Root Cause

File: server/routes/dashboard.js

The enrichment function decorateRequestsWithArrLinks() is only called for Ombi requests:

// Admin only: add Sonarr/Radarr lookup links
if (isAdmin) {
  const allFiltered = [...filteredOmbiMovieRequests, ...filteredOmbiTvRequests];
  await decorateRequestsWithArrLinks(allFiltered, isAdmin);
}

Active downloads (the main list shown on the dashboard) are built via:

const userDownloads = await buildUserDownloads(userId, ...);

These regular download items (from Sonarr/Radarr queues + download clients) are never passed to decorateRequestsWithArrLinks().

Frontend Impact

File: client/src/ui/downloads.js

The Radarr button is rendered only if download.arrLink exists:

if (state.isAdmin && download.arrLink) {
  // create Radarr icon + link
  if (download.arrType === 'radarr') { ... }
}

Since arrLink is never populated for active movie downloads, the condition is never true.

Impact

  • Administrators lose one-click navigation to Radarr from active movie downloads.
  • Inconsistent experience between Ombi requests and active downloads.
  • The feature was only partially implemented (Ombi section only).

Proposed Fix

Extend the admin link decoration to also cover active downloads.

Recommended Change in server/routes/dashboard.js

After building userDownloads, add:

if (isAdmin) {
  // Existing Ombi requests decoration
  const allFiltered = [...filteredOmbiMovieRequests, ...filteredOmbiTvRequests];
  await decorateRequestsWithArrLinks(allFiltered, isAdmin);

  // NEW: Also decorate active downloads
  await decorateDownloadsWithArrLinks(userDownloads, isAdmin);
}

Then implement (or reuse) decorateDownloadsWithArrLinks() in server/utils/ombiHelpers.js (or a new utility) to add arrLink and arrType to movie/TV downloads based on their source (radarr / sonarr).

Additional Notes

  • This bug was introduced when the admin deep-link feature was added — it was only wired up for the Ombi requests section.
  • The same issue affects active TV downloads (missing Sonarr button).
  • The recent fix for Ombi TV requests (fix: resolve missing Sonarr link button on TV request cards) did not address active downloads.

Environment

  • sofarr version: v1.7.28
  • User Role: Admin
  • Services: Radarr + any download client
## Summary The **Radarr deep-link button** is missing from **active movie downloads** on the main dashboard. Administrators who have Radarr configured do **not** see the Radarr icon/link next to active movie downloads (from Radarr queues, SABnzbd, qBittorrent, etc.), even though the equivalent feature works for Ombi movie requests (after the fix in v1.7.28). --- ## Steps to Reproduce 1. Log in as an **admin** user. 2. Ensure Radarr is configured and has active downloads. 3. Go to the main **Dashboard** (active downloads section). 4. Look at any active movie download card. 5. **Expected**: Radarr icon/link button visible (clickable deep link to the movie in Radarr). 6. **Actual**: No Radarr icon or link appears. --- ## Expected Behavior Active movie downloads should display a clickable Radarr icon (similar to how Ombi movie requests now show it after the recent fix) that takes the admin directly to the movie in Radarr. --- ## Actual Behavior - No Radarr link button appears on active movie download cards. - The button works correctly on **Ombi movie requests** (thanks to the v1.7.28 fix). - Sonarr links are also missing on active TV downloads (same root cause). --- ## Root Cause Analysis ### Confirmed Root Cause **File:** `server/routes/dashboard.js` The enrichment function `decorateRequestsWithArrLinks()` is **only called for Ombi requests**: ```javascript // Admin only: add Sonarr/Radarr lookup links if (isAdmin) { const allFiltered = [...filteredOmbiMovieRequests, ...filteredOmbiTvRequests]; await decorateRequestsWithArrLinks(allFiltered, isAdmin); } ``` **Active downloads** (the main list shown on the dashboard) are built via: ```javascript const userDownloads = await buildUserDownloads(userId, ...); ``` These regular download items (from Sonarr/Radarr queues + download clients) are **never passed** to `decorateRequestsWithArrLinks()`. ### Frontend Impact **File:** `client/src/ui/downloads.js` The Radarr button is rendered only if `download.arrLink` exists: ```javascript if (state.isAdmin && download.arrLink) { // create Radarr icon + link if (download.arrType === 'radarr') { ... } } ``` Since `arrLink` is never populated for active movie downloads, the condition is never true. --- ## Impact - Administrators lose one-click navigation to Radarr from active movie downloads. - Inconsistent experience between Ombi requests and active downloads. - The feature was only partially implemented (Ombi section only). --- ## Proposed Fix Extend the admin link decoration to also cover active downloads. ### Recommended Change in `server/routes/dashboard.js` After building `userDownloads`, add: ```javascript if (isAdmin) { // Existing Ombi requests decoration const allFiltered = [...filteredOmbiMovieRequests, ...filteredOmbiTvRequests]; await decorateRequestsWithArrLinks(allFiltered, isAdmin); // NEW: Also decorate active downloads await decorateDownloadsWithArrLinks(userDownloads, isAdmin); } ``` Then implement (or reuse) `decorateDownloadsWithArrLinks()` in `server/utils/ombiHelpers.js` (or a new utility) to add `arrLink` and `arrType` to movie/TV downloads based on their source (`radarr` / `sonarr`). --- ## Additional Notes - This bug was introduced when the admin deep-link feature was added — it was only wired up for the Ombi requests section. - The same issue affects active TV downloads (missing Sonarr button). - The recent fix for Ombi TV requests (`fix: resolve missing Sonarr link button on TV request cards`) did not address active downloads. --- ## Environment - **sofarr version:** v1.7.28 - **User Role:** Admin - **Services:** Radarr + any download client
Gandalf added the Kind/Bug
Priority
Medium
3
 labels 2026-05-27 23:35:27 +01:00
Gandalf added reference release/1.7.28 2026-05-27 23:35:34 +01:00
Gandalf commented 2026-05-27 23:52:20 +01:00
Author
Owner
Copy Link
Copy Source

Resolved in commit 13f3d767c5.

Resolved in commit 13f3d767c565ed94feb872022074c208476b513f.
Sign in to join this conversation.
release/1.7.28
Branches Tags
Labels
Clear labels
Area/Docker
Docker image and container packaging
 Area/Download Clients
Download client integrations
 Area/Frontend
Client-side UI and build tooling
 Area/History
History and completed downloads views
 Area/Logging
Log streaming, file handling, and debug infrastructure
 Area/Matching
Matching and correlation logic
 Area/Proxy
Upstream service proxy routes
 Area/SSE
Server-Sent Events and real-time streaming
 Area/Webhooks
Webhook processing and reliability
 Compat/Breaking
Breaking change that won't be backward compatible
 Compat/Non-Breaking
Non-breaking compatibility change
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Kind/Bug
Priority
Medium
3
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Gandalf
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Gandalf/sofarr#59
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?