Gandalf/sofarr
Public Access
0
0
Fork 0
Code Issues 1 Pull Requests Actions 1 Packages Projects Releases 59 Wiki Activity

BUG: Newly created requests in Ombi are not shown in requests tab #42

New Issue
Closed
opened 2026-05-23 10:29:44 +01:00 by Gandalf · 7 comments
Gandalf commented 2026-05-23 10:29:44 +01:00
Owner
Copy Link
Copy Source

Problem:
When creating a request in Ombi, the request does not appear in the requests tab as expected

To replicate:
Create a request in Ombi for the current user. Sort requests tab by newest to oldest. Request does not appear.

**Problem:** When creating a request in Ombi, the request does not appear in the requests tab as expected **To replicate:** Create a request in Ombi for the current user. Sort requests tab by newest to oldest. Request does not appear.
Gandalf added the Kind/Bug
Priority
Medium
3
 labels 2026-05-23 10:29:44 +01:00
Gandalf commented 2026-05-23 18:55:24 +01:00
Author
Owner
Copy Link
Copy Source

Resolved in v1.7.6. Implemented a force cache-bypass upon receiving webhooks or manual requests reload.

Resolved in v1.7.6. Implemented a force cache-bypass upon receiving webhooks or manual requests reload.
Gandalf reopened this issue 2026-05-23 20:32:49 +01:00
Gandalf commented 2026-05-23 20:35:11 +01:00
Author
Owner
Copy Link
Copy Source

Investigating: Identified that the webhook payload is being rejected with 400 Bad Request because 'NewRequest' is not in the valid/ombi allowed event type sets. Starting the fix now.

Investigating: Identified that the webhook payload is being rejected with 400 Bad Request because 'NewRequest' is not in the valid/ombi allowed event type sets. Starting the fix now.
Gandalf commented 2026-05-23 20:36:00 +01:00
Author
Owner
Copy Link
Copy Source

Resolution: Added 'NewRequest' to the backend allowed event type sets (VALID_EVENT_TYPES and OMBI_EVENTS) in server/routes/webhook.js. This allows the backend to successfully accept and process the NewRequest webhook payload, fetching the latest request list from Ombi and refreshing the cache accordingly. Additionally, added a complete integration test suite in tests/integration/webhook.test.js that verifies secret validation, input checks, duplicate/replay protection, and cache refresh logic. All tests are passing successfully.

Resolution: Added 'NewRequest' to the backend allowed event type sets (VALID_EVENT_TYPES and OMBI_EVENTS) in server/routes/webhook.js. This allows the backend to successfully accept and process the NewRequest webhook payload, fetching the latest request list from Ombi and refreshing the cache accordingly. Additionally, added a complete integration test suite in tests/integration/webhook.test.js that verifies secret validation, input checks, duplicate/replay protection, and cache refresh logic. All tests are passing successfully.
Gandalf reopened this issue 2026-05-23 20:49:32 +01:00
Gandalf commented 2026-05-23 20:51:17 +01:00
Author
Owner
Copy Link
Copy Source

Issue reopened. Investigated Ombi payload casing and applied a fix to handle PascalCase properties like NotificationType, which C#/.NET applications often send instead of camelCase.

Issue reopened. Investigated Ombi payload casing and applied a fix to handle PascalCase properties like `NotificationType`, which C#/.NET applications often send instead of camelCase.
Gandalf commented 2026-05-23 20:54:59 +01:00
Author
Owner
Copy Link
Copy Source

Fix released in v1.7.8. Commit: 9548eb41f5

Fix released in v1.7.8. Commit: 9548eb41f5a1b0d1172d29ae3ee92d3d884edae4
Gandalf reopened this issue 2026-05-23 20:59:13 +01:00
Gandalf commented 2026-05-23 20:59:15 +01:00
Author
Owner
Copy Link
Copy Source

Fix correctly released in v1.7.9. Resolving commit: d4ee3b8ef7

Fix correctly released in v1.7.9. Resolving commit: d4ee3b8ef7278362f7986d52e6861b21a66711e0
Gandalf reopened this issue 2026-05-24 10:21:34 +01:00
Gandalf commented 2026-05-24 10:22:58 +01:00
Author
Owner
Copy Link
Copy Source

Resolved in commit 9491948ec9.

Resolved in commit 9491948ec966a1b92f1750077cbbc72b973c7979.
Gandalf added the Area/Proxy label 2026-05-28 11:58:28 +01:00
Sign in to join this conversation.
release/1.7.5
Branches Tags
Labels
Clear labels
Area/Docker
Docker image and container packaging
 Area/Download Clients
Download client integrations
 Area/Frontend
Client-side UI and build tooling
 Area/History
History and completed downloads views
 Area/Logging
Log streaming, file handling, and debug infrastructure
 Area/Matching
Matching and correlation logic
 Area/Proxy
Upstream service proxy routes
 Area/SSE
Server-Sent Events and real-time streaming
 Area/Webhooks
Webhook processing and reliability
 Compat/Breaking
Breaking change that won't be backward compatible
 Compat/Non-Breaking
Non-breaking compatibility change
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Area/Proxy Kind/Bug
Priority
Medium
3
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Gandalf
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Gandalf/sofarr#42
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?