Gandalf/sofarr
Public Access
0
0
Fork 0
Code Issues 1 Pull Requests Actions 1 Packages Projects Releases 59 Wiki Activity

BUG: Ombi webhook not actually enabled on Ombi side due to missing ID in settings payload #41

New Issue
Closed
opened 2026-05-23 10:10:30 +01:00 by Gandalf · 1 comment
Gandalf commented 2026-05-23 10:10:30 +01:00
Owner
Copy Link
Copy Source

Bug Description

While the Ombi webhook enable button no longer returns a 404, clicking it does not actually enable the webhook on the Ombi side. The webhook remains disabled.

Root Cause

  1. In server/routes/ombi.js, POST /api/ombi/webhook/enable calls POST {ombi}/api/v1/Settings/notifications/webhook with the payload: 
    {
  "enabled": true,
  "webhookUrl": "...",
  "applicationToken": "..."
}
  2. According to Ombi's Swagger documentation, the WebhookNotificationViewModel schema contains an id property.
  3. In Ombi's backend (ASP.NET Core / Entity Framework), setting updates require the existing database record id to be passed. If it is omitted or set to 0, Entity Framework Core fails to perform the update on the single settings row, causing the change to not persist even if the HTTP request returns 200.

Remediation Plan

  1. In server/routes/ombi.js, update POST /api/ombi/webhook/enable to first perform a GET request to GET {ombi}/api/v1/Settings/notifications/webhook to retrieve the current webhook configuration and its database id.
  2. Merge the id from the retrieved configuration into the payload of the subsequent POST request.
### Bug Description While the Ombi webhook enable button no longer returns a 404, clicking it does not actually enable the webhook on the Ombi side. The webhook remains disabled. ### Root Cause 1. In `server/routes/ombi.js`, `POST /api/ombi/webhook/enable` calls `POST {ombi}/api/v1/Settings/notifications/webhook` with the payload: ```json { "enabled": true, "webhookUrl": "...", "applicationToken": "..." } ``` 2. According to Ombi's Swagger documentation, the `WebhookNotificationViewModel` schema contains an `id` property. 3. In Ombi's backend (ASP.NET Core / Entity Framework), setting updates require the existing database record `id` to be passed. If it is omitted or set to `0`, Entity Framework Core fails to perform the update on the single settings row, causing the change to not persist even if the HTTP request returns 200. ### Remediation Plan 1. In `server/routes/ombi.js`, update `POST /api/ombi/webhook/enable` to first perform a `GET` request to `GET {ombi}/api/v1/Settings/notifications/webhook` to retrieve the current webhook configuration and its database `id`. 2. Merge the `id` from the retrieved configuration into the payload of the subsequent `POST` request.
Gandalf added the Kind/Bug
Priority
High
2
 labels 2026-05-23 10:10:30 +01:00
Gandalf commented 2026-05-23 10:12:32 +01:00
Author
Owner
Copy Link
Copy Source

Reopened and successfully closed via commit de71580756dfc5bb88b78c7d0cf05f297a1ce441 on the develop branch.

Added fetching of existing Ombi webhook settings prior to enabling the webhook. The retrieved settings id is now merged back into the POST payload. This guarantees that Entity Framework on the Ombi backend performs an update on the correct database row, enabling the webhook successfully and allowing its state to persist correctly.

Reopened and successfully closed via commit [de71580756dfc5bb88b78c7d0cf05f297a1ce441](https://git.i3omb.com/Gandalf/sofarr/commit/de71580756dfc5bb88b78c7d0cf05f297a1ce441) on the `develop` branch. Added fetching of existing Ombi webhook settings prior to enabling the webhook. The retrieved settings `id` is now merged back into the `POST` payload. This guarantees that Entity Framework on the Ombi backend performs an update on the correct database row, enabling the webhook successfully and allowing its state to persist correctly.
Gandalf added the Area/Proxy label 2026-05-28 11:58:29 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Docker
Docker image and container packaging
 Area/Download Clients
Download client integrations
 Area/Frontend
Client-side UI and build tooling
 Area/History
History and completed downloads views
 Area/Logging
Log streaming, file handling, and debug infrastructure
 Area/Matching
Matching and correlation logic
 Area/Proxy
Upstream service proxy routes
 Area/SSE
Server-Sent Events and real-time streaming
 Area/Webhooks
Webhook processing and reliability
 Compat/Breaking
Breaking change that won't be backward compatible
 Compat/Non-Breaking
Non-breaking compatibility change
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Area/Proxy Kind/Bug
Priority
High
2
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Gandalf
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Gandalf/sofarr#41
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?