Gandalf/sofarr
Public Access
0
0
Fork 0
Code Issues 1 Pull Requests Actions 1 Packages Projects Releases 59 Wiki Activity

BUG: getActiveDownloads makes redundant concurrent HTTP requests to SABnzbd queue endpoint #36

New Issue
Closed
opened 2026-05-22 19:11:10 +01:00 by Gandalf · 1 comment
Gandalf commented 2026-05-22 19:11:10 +01:00
Owner
Copy Link
Copy Source

Problem Location

  • File: server/clients/SABnzbdClient.js
  • Lines: 45-52 (within getActiveDownloads) and lines 93-100 (within getClientStatus)

Issue Details

In SABnzbdClient.js, the getActiveDownloads() method initiates concurrent requests using Promise.all:

      // Get both queue and history to provide complete picture
      const [queueResponse, historyResponse, clientStatus] = await Promise.all([
        this.makeRequest({ mode: 'queue' }),
        this.makeRequest({ mode: 'history', limit: 10 }),
        this.getClientStatus()
      ]);

However, looking at the implementation of getClientStatus():

  async getClientStatus() {
    try {
      const response = await this.makeRequest({ mode: 'queue' });
      const queueData = response.data.queue;
      ...

We see that getClientStatus() internally makes the exact same this.makeRequest({ mode: 'queue' }) request.
As a result, calling getActiveDownloads() triggers two concurrent and identical requests to the SABnzbd /api?mode=queue endpoint during every polling cycle. This redundant HTTP overhead wastes SABnzbd instance CPU/memory resource, network bandwidth, and application memory, especially when polling frequently.

Proposed Fix

Avoid calling this.getClientStatus() concurrently in getActiveDownloads() when we already have the queue response. Instead, extract the client status directly from the fetched queueResponse data.

Specifically, in getActiveDownloads(), query queue and history in parallel, and then construct the clientStatus info directly from queueData.queue. This eliminates the redundant API request entirely.

### Problem Location - **File**: `server/clients/SABnzbdClient.js` - **Lines**: 45-52 (within `getActiveDownloads`) and lines 93-100 (within `getClientStatus`) ### Issue Details In `SABnzbdClient.js`, the `getActiveDownloads()` method initiates concurrent requests using `Promise.all`: ```javascript // Get both queue and history to provide complete picture const [queueResponse, historyResponse, clientStatus] = await Promise.all([ this.makeRequest({ mode: 'queue' }), this.makeRequest({ mode: 'history', limit: 10 }), this.getClientStatus() ]); ``` However, looking at the implementation of `getClientStatus()`: ```javascript async getClientStatus() { try { const response = await this.makeRequest({ mode: 'queue' }); const queueData = response.data.queue; ... ``` We see that `getClientStatus()` internally makes the exact same `this.makeRequest({ mode: 'queue' })` request. As a result, calling `getActiveDownloads()` triggers two concurrent and identical requests to the SABnzbd `/api?mode=queue` endpoint during every polling cycle. This redundant HTTP overhead wastes SABnzbd instance CPU/memory resource, network bandwidth, and application memory, especially when polling frequently. ### Proposed Fix Avoid calling `this.getClientStatus()` concurrently in `getActiveDownloads()` when we already have the queue response. Instead, extract the client status directly from the fetched `queueResponse` data. Specifically, in `getActiveDownloads()`, query queue and history in parallel, and then construct the clientStatus info directly from `queueData.queue`. This eliminates the redundant API request entirely.
Gandalf added the Kind/Bug label 2026-05-22 19:16:27 +01:00
Gandalf commented 2026-05-22 22:25:35 +01:00
Author
Owner
Copy Link
Copy Source

Resolved via commit 12c44a6 (removed redundant getClientStatus call).

Resolved via commit 12c44a6 (removed redundant getClientStatus call).
Gandalf added the Area/Download Clients label 2026-05-28 11:53:52 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Docker
Docker image and container packaging
 Area/Download Clients
Download client integrations
 Area/Frontend
Client-side UI and build tooling
 Area/History
History and completed downloads views
 Area/Logging
Log streaming, file handling, and debug infrastructure
 Area/Matching
Matching and correlation logic
 Area/Proxy
Upstream service proxy routes
 Area/SSE
Server-Sent Events and real-time streaming
 Area/Webhooks
Webhook processing and reliability
 Compat/Breaking
Breaking change that won't be backward compatible
 Compat/Non-Breaking
Non-breaking compatibility change
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Area/Download Clients Kind/Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Gandalf
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Gandalf/sofarr#36
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?