BUG: getDownloadsByClientType executes sequential blocking awaits on download clients instead of parallel promises #35

New Issue

2026-05-22T19:10:31+01:00

Gandalf commented

2026-05-22 19:10:31 +01:00

Problem Location

File: server/utils/downloadClients.js
Lines: 148-173 (within getDownloadsByClientType)
Affected Downstream: server/utils/poller.js (line 112)

Issue Details

In DownloadClientRegistry.getDownloadsByClientType(), the method retrieves all configured download clients and iterates over them sequentially using a for (const client of clients) loop:

    for (const client of clients) {
      const type = client.getClientType();
      ...
      try {
        const downloads = await client.getActiveDownloads();
        result[type].push(...downloads);
      } catch (error) {
        ...
      }
    }

Because of the sequential await client.getActiveDownloads();, if one client is slow, unresponsive, or experiencing network/timeout issues, the entire polling cycle is blocked. If multiple clients timeout, the latency accumulates linearly.

In contrast, getAllDownloads() correctly uses Promise.allSettled to query all clients in parallel and then aggregates the results, which prevents a single slow client from stalling the entire system.

Because the main background poller at server/utils/poller.js relies directly on getDownloadsByClientType() to update active downloads, this sequential behavior has a severe performance impact on the dashboard, making real-time SSE updates sluggish or completely stalled.

Proposed Fix

Refactor getDownloadsByClientType() to query all clients concurrently using Promise.allSettled, and then group the resolved downloads by client type.

### Problem Location - **File**: `server/utils/downloadClients.js` - **Lines**: 148-173 (within `getDownloadsByClientType`) - **Affected Downstream**: `server/utils/poller.js` (line 112) ### Issue Details In `DownloadClientRegistry.getDownloadsByClientType()`, the method retrieves all configured download clients and iterates over them sequentially using a `for (const client of clients)` loop: ```javascript for (const client of clients) { const type = client.getClientType(); ... try { const downloads = await client.getActiveDownloads(); result[type].push(...downloads); } catch (error) { ... } } ``` Because of the sequential `await client.getActiveDownloads();`, if one client is slow, unresponsive, or experiencing network/timeout issues, the entire polling cycle is blocked. If multiple clients timeout, the latency accumulates linearly. In contrast, `getAllDownloads()` correctly uses `Promise.allSettled` to query all clients in parallel and then aggregates the results, which prevents a single slow client from stalling the entire system. Because the main background poller at `server/utils/poller.js` relies directly on `getDownloadsByClientType()` to update active downloads, this sequential behavior has a severe performance impact on the dashboard, making real-time SSE updates sluggish or completely stalled. ### Proposed Fix Refactor `getDownloadsByClientType()` to query all clients concurrently using `Promise.allSettled`, and then group the resolved downloads by client type.

Gandalf added the Kind/Bug label 2026-05-22 19:16:27 +01:00

Gandalf commented

2026-05-22 22:25:34 +01:00

Resolved via commit 12c44a6 (parallel polling).

Resolved via commit 12c44a6 (parallel polling).

Gandalf closed this issue

2026-05-22 22:25:34 +01:00

Gandalf referenced this issue from a commit

2026-05-22 22:43:38 +01:00

fix: optimize polling parallelism and resolve redundant SABnzbd requests (fixes #35, fixes #36)

Gandalf added the Area/Download Clients label 2026-05-28 11:53:52 +01:00

Sign in to join this conversation.

Branches Tags

main

release/1.7.38

develop

release/1.7.37

release/1.7.36

release/1.7.35

release/1.7.34

release/1.7.33

release/1.7.32

release/1.7.31

release/1.7.30

release/1.7.29

release/1.7.28

release/1.7.27

release/1.7.26

release/1.7.25

release/1.7.24

release/1.7.23

release/1.7.22

release/1.7.21

release/1.7.20

release/1.7.19

release/1.7.18

release/1.7.17

release/1.7.16

release/1.7.15

release/1.7.14

release/1.7.13

release/1.7.12

release/1.7.11

release/1.7.10

release/1.7.9

release/1.7.8

release/1.7.7

release/1.7.6

release/1.7.5

release/1.7.4

release/1.7.3

release/1.6.0

release/1.5.5

release/1.5.3

release/1.5.2

release/1.5.0a

release/1.4.0

release/1.3.1a

release/1.3.1

release/1.3.0

release/v1.2.2

release/v1.2.1

release/v1.2.0

release/1.1.2

release/1.1.1

release/1.1.0

release/1.0.0

release/0.2.0

release/v0.1.5

release/0.1.4

release/0.1.3

release/0.1

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Gandalf/sofarr#35