Gandalf/sofarr
Public Access
0
0
Fork 0
Code Issues 1 Pull Requests Actions 1 Packages Projects Releases 59 Wiki Activity

BUG: Proxy routes use legacy single-instance environment variables instead of multi-instance config #33

New Issue
Closed
opened 2026-05-22 18:53:22 +01:00 by Gandalf · 1 comment
Gandalf commented 2026-05-22 18:53:22 +01:00
Owner
Copy Link
Copy Source

Summary

The proxy routes for Sonarr, Radarr, and SABnzbd (/queue, /history, /series, /notifications/:id, /notifications (POST/PUT/DELETE), etc.) bypass the modern multi-instance configurations and are hardcoded to use legacy single-instance environment variables (process.env.SONARR_URL, process.env.SONARR_API_KEY, etc.).

Root Cause

In server/routes/sonarr.js, server/routes/radarr.js, and server/routes/sabnzbd.js, endpoints retrieve information by direct request using the legacy environment variables:

const response = await axios.get(`${process.env.SONARR_URL}/api/v3/queue`, {
  headers: { 'X-Api-Key': process.env.SONARR_API_KEY }
});

This is inconsistent with other parts of the system, such as server/utils/config.js and some /notifications endpoints, which correctly use multi-instance configurations (e.g. getSonarrInstances()).

Impact

In environments configured exclusively with the modern multi-instance JSON arrays (e.g. SONARR_INSTANCES), these proxy routes will fail completely with connection errors or TypeError because legacy environment variables are undefined.

Steps to Reproduce

  1. Configure SONARR_INSTANCES via JSON array in the environment variables, leaving SONARR_URL and SONARR_API_KEY undefined.
  2. Log in and hit the /api/sonarr/queue or /api/sonarr/history endpoint.
  3. The request will fail with an error or a TypeError since process.env.SONARR_URL is undefined.

Proposed Fix

Update these route controllers to:

  1. Import configuration instance getters (e.g., getSonarrInstances(), getRadarrInstances(), getSABnzbdInstances()).
  2. Implement fallback logic to retrieve the first configured instance as default (using helpers like getFirstSonarrInstance() for all endpoints in the router).
  3. Update all AXIOS requests to use instance.url and instance.apiKey dynamically.
### Summary The proxy routes for Sonarr, Radarr, and SABnzbd (`/queue`, `/history`, `/series`, `/notifications/:id`, `/notifications` (POST/PUT/DELETE), etc.) bypass the modern multi-instance configurations and are hardcoded to use legacy single-instance environment variables (`process.env.SONARR_URL`, `process.env.SONARR_API_KEY`, etc.). ### Root Cause In `server/routes/sonarr.js`, `server/routes/radarr.js`, and `server/routes/sabnzbd.js`, endpoints retrieve information by direct request using the legacy environment variables: ```javascript const response = await axios.get(`${process.env.SONARR_URL}/api/v3/queue`, { headers: { 'X-Api-Key': process.env.SONARR_API_KEY } }); ``` This is inconsistent with other parts of the system, such as `server/utils/config.js` and some `/notifications` endpoints, which correctly use multi-instance configurations (e.g. `getSonarrInstances()`). ### Impact In environments configured exclusively with the modern multi-instance JSON arrays (e.g. `SONARR_INSTANCES`), these proxy routes will fail completely with connection errors or `TypeError` because legacy environment variables are undefined. ### Steps to Reproduce 1. Configure `SONARR_INSTANCES` via JSON array in the environment variables, leaving `SONARR_URL` and `SONARR_API_KEY` undefined. 2. Log in and hit the `/api/sonarr/queue` or `/api/sonarr/history` endpoint. 3. The request will fail with an error or a `TypeError` since `process.env.SONARR_URL` is undefined. ### Proposed Fix Update these route controllers to: 1. Import configuration instance getters (e.g., `getSonarrInstances()`, `getRadarrInstances()`, `getSABnzbdInstances()`). 2. Implement fallback logic to retrieve the first configured instance as default (using helpers like `getFirstSonarrInstance()` for all endpoints in the router). 3. Update all AXIOS requests to use `instance.url` and `instance.apiKey` dynamically.
Gandalf added the Kind/Bug label 2026-05-22 19:16:27 +01:00
Gandalf commented 2026-05-22 22:32:04 +01:00
Author
Owner
Copy Link
Copy Source

Resolved via commit 2e9fe8e.

Resolved via commit 2e9fe8e.
Gandalf added the Area/Proxy label 2026-05-28 11:53:58 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Area/Docker
Docker image and container packaging
 Area/Download Clients
Download client integrations
 Area/Frontend
Client-side UI and build tooling
 Area/History
History and completed downloads views
 Area/Logging
Log streaming, file handling, and debug infrastructure
 Area/Matching
Matching and correlation logic
 Area/Proxy
Upstream service proxy routes
 Area/SSE
Server-Sent Events and real-time streaming
 Area/Webhooks
Webhook processing and reliability
 Compat/Breaking
Breaking change that won't be backward compatible
 Compat/Non-Breaking
Non-breaking compatibility change
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Area/Proxy Kind/Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Gandalf
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Gandalf/sofarr#33
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?