13 Commits

Author	SHA1	Message	Date
gronod	47817d057b	Fix status route test paths ... - Update test paths from /api/status/status to /api/status - Matches the route change from /status to / in status.js	2026-05-21 01:51:00 +01:00
gronod	05c9527189	Add comprehensive tests for staged history loading ... Unit tests: - Staged loading (initial batch, background fetch, concurrent requests) - Deduplication (by record ID, empty record sets) - Event subscription (subscribe/unsubscribe, error handling) - Pagination (max records limit, batch sizes) Integration tests: - Race conditions (concurrent requests, cache consistency, duplicate handling) - Edge cases (empty history, single record, batch boundaries) Tests verify: - No records are missed during staged loading - No duplicates are created - Cache remains consistent during concurrent operations - Background fetch doesn't interfere with concurrent user requests	2026-05-21 01:28:37 +01:00
gronod	a38fc4a8ce	refactor: extract status route and WebhookStatus service, slim dashboard.js ... - Extract /status route to server/routes/status.js - Create server/services/WebhookStatus.js with checkWebhookConfigured and aggregateMetrics - Slim dashboard.js to pure HTTP orchestration (559→283 lines, 49.4% reduction) - Remove /user-summary and /webhook-metrics routes from dashboard.js - Mount status router at /api/status in server/index.js and server/app.js - Update tests to use new /api/status/status endpoint - Fix test expectation for speed field (number vs string) All 571 tests passing.	2026-05-20 22:50:40 +01:00
gronod	7d3e6e6a47	test: add integration and unit tests for dashboard, emby, sonarr, radarr, sabnzbd routes ... - tests/unit/dashboard.test.js: 58 unit tests covering all 12 pure helper functions in dashboard.js (sanitizeTagLabel, tagMatchesUser, getCoverArt, extractAllTags, extractUserTag, getImportIssues, getSonarrLink, getRadarrLink, canBlocklist, extractEpisode, gatherEpisodes, buildTagBadges) - tests/integration/dashboard.test.js: 35 integration tests for /user-downloads (SAB+Sonarr, SAB+Radarr, qBit, showAll, paused queue, history matching, importIssues, wrong-user filtering), /status (admin guard, webhook check, failure handling), /webhook-metrics, /cover-art (all validation/proxy paths), /blocklist-search (guards, Sonarr, Radarr, failure) - tests/integration/emby.test.js: 13 integration tests covering all 4 Emby routes (sessions, users, users/:id, session/:id/user) with auth guard, happy path, and upstream failure cases - tests/integration/arrRoutes.test.js: 64 integration tests for Sonarr + Radarr (queue, history, series/movies, notifications CRUD, /test, /schema, /sofarr-webhook create+update+missing-config+failure) and SABnzbd (queue, history with custom params) - vitest.config.js: raise global coverage thresholds (statements/functions/ lines 20->55, branches 8->40) to reflect improved coverage (62.5% stmts, 42.6% branches, 64.1% funcs, 65.6% lines) - tests/README.md: document new test files and update coverage table	2026-05-20 21:37:57 +01:00
gronod	1bef14d590	feat(webhooks): security hardening, tests, full documentation audit & polish (Phase 6)	2026-05-19 17:11:45 +01:00
gronod	9343486705	Fix all Vitest test failures after migration ... - Replace vi.mock('axios') with nock for HTTP request mocking (ES/CJS interop issue) - Fix RTorrentClient by mocking client.client.methodCall directly instead of xmlrpc module - Fix downloadClients.test.js by manually adding mock clients to registry - Fix qbittorrent.test.js to use getActiveDownloads() and normalized properties - Fix integration test env var mocks and error assertions - Fix SABnzbdClient size parsing and test fixtures - Fix RTorrentClient ETA calculation expectation All 261 tests now passing.	2026-05-19 13:53:09 +01:00
gronod	5342170ced	fix: convert test files to ES modules and fix qbittorrent test method calls ... - Convert all client test files from CommonJS require() to ES module import syntax - Convert downloadClients.test.js and integration/downloadClients.test.js to ES modules - Fix qbittorrent.test.js to use getActiveDownloads() instead of getTorrents() - All test files now use proper Vitest-compatible ES module syntax - Resolves Vitest import errors and QBittorrentClient method call errors	2026-05-19 12:19:04 +01:00
gronod	cc0e34b3d1	fix: convert all test files from jest to vitest and fix QBittorrentClient import ... - Convert RTorrentClient.test.js to use vi.mock() instead of jest.mock() - Convert QBittorrentClient.test.js to use vi.mock() instead of jest.mock() - Convert SABnzbdClient.test.js to use vi.mock() instead of jest.mock() - Convert TransmissionClient.test.js to use vi.mock() instead of jest.mock() - Convert downloadClients.test.js to use vi.mock() instead of jest.mock() - Convert integration/downloadClients.test.js to use vi.mock() instead of jest.mock() - Fix legacy qbittorrent.test.js to import QBittorrentClient from new location - Add getRtorrentInstances mock to downloadClients.test.js - Add RTORRENT_INSTANCES to integration test environment variables	2026-05-19 12:12:44 +01:00
gronod	bf3e1c353d	Implement Pluggable Download Client Architecture (PDCA) ... - Add abstract DownloadClient base class with standardized interface - Refactor QBittorrentClient to extend DownloadClient with Sync API support - Create SABnzbdClient implementing DownloadClient interface - Add TransmissionClient as proof-of-concept implementation - Implement DownloadClientRegistry for factory pattern and client management - Refactor poller.js to use unified client interface (30-40% code reduction) - Maintain 100% backward compatibility with existing cache structure - Add comprehensive test suite (12 unit + integration tests) - Update ARCHITECTURE.md with detailed PDCA documentation - Create ADDING-A-DOWNLOAD-CLIENT.md guide for future client additions Features: - Client-agnostic polling with error isolation - Consistent data normalization across all clients - Easy extensibility for new download client types - Zero breaking changes to existing functionality - Parallel execution with unified timing and logging	2026-05-19 11:18:19 +01:00
gronod	8c4cc20551	Add MIT copyright headers to all source files	2026-05-19 09:07:42 +01:00
gronod	6139095444	feat: deduplicate history — suppress failed records superseded by successful import, flag failed+hasFile as availableForUpgrade	2026-05-17 21:52:55 +01:00
gronod	57b3254f70	test(history): add unit and integration tests for historyFetcher and /api/history/recent	2026-05-17 12:05:45 +01:00
gronod	5fd55b4e1a	test: add comprehensive test suite (115 tests, Vitest + supertest + nock) ... Framework: - Vitest v4 as test runner (fast ESM/CJS support, V8 coverage built-in) - supertest for integration tests against createApp() factory - nock for HTTP interception (works with CJS require('axios'), unlike vi.mock) New files: - vitest.config.js — test config: node env, isolate, V8 coverage, per-file thresholds - tests/setup.js — isolated DATA_DIR per worker, SKIP_RATE_LIMIT, console suppression - tests/README.md — approach, structure, design decisions - server/app.js — testable Express factory (extracted from index.js side-effects) Unit tests (91 tests): - tests/unit/sanitizeError.test.js — secret redaction: apikey, token, bearer, basic-auth URLs - tests/unit/config.test.js — JSON array + legacy single-instance config parsing - tests/unit/requireAuth.test.js — valid/invalid/tampered cookies, schema validation - tests/unit/verifyCsrf.test.js — double-submit pattern, timing-safe compare, safe methods - tests/unit/qbittorrent.test.js — formatBytes, formatEta, mapTorrentToDownload state map - tests/unit/tokenStore.test.js — store/get/clear lifecycle, TTL expiry, atomic disk write Integration tests (24 tests): - tests/integration/health.test.js — /health and /ready endpoints - tests/integration/auth.test.js — full login/logout/me/csrf flows, input validation, cookie attributes, no token leakage, Emby mock via nock Production code changes (minimal, no behaviour change): - server/routes/auth.js: EMBY_URL captured at request-time (not module load) for testability - server/routes/auth.js: loginLimiter max → Number.MAX_SAFE_INTEGER when SKIP_RATE_LIMIT set - server/utils/sanitizeError.js: fix HEADER_PATTERN to redact full line (not just first token) CI: - .gitea/workflows/ci.yml: add parallel 'test' job (npm run test:coverage, artifact upload) - package.json: add test/test:watch/test:coverage/test:ui scripts - .gitignore: add coverage/	2026-05-17 07:45:33 +01:00