Gandalf/OctoPrint-Enclosure
1
0
Fork 0
Code Issues 156 Pull Requests 6 Actions Packages Projects Releases 28 Wiki Activity

Use RPi.bme280 #444

Merged
thijstriemstra merged 6 commits from patch-1 into master 2021-11-10 09:04:05 +00:00
Conversation 1 Commits 6 Files Changed 3 +25 -148
thijstriemstra commented 2021-10-26 20:47:40 +01:00 (Migrated from github.com)
Copy Link

This PR introduces usage of RPi.bme280 library, simplifying the temperature/humidity reading code.

It also makes sure the correct python executable is used when running the script. It was using system python before which resolves to /usr/bin/python2.7 on Raspbian, which is plain wrong I think. sys.executable resolves to the Python executable that octoprint uses, so the command becomes:

/home/pi/oprint/bin/python3 /home/pi/oprint/lib/python3.7/site-packages/octoprint_enclosure/BME280.py 0x76

instead of:

python /home/pi/oprint/lib/python3.7/site-packages/octoprint_enclosure/BME280.py 0x76

Lastly, it also properly logs errors that occur in the BME280.py script.

Tested with Octopi 0.18.0 and octoprint 1.7.0.

This PR introduces usage of RPi.bme280 library, simplifying the temperature/humidity reading code. It also makes sure the correct python executable is used when running the script. It was using system `python` before which resolves to `/usr/bin/python2.7` on Raspbian, which is plain wrong I think. `sys.executable` resolves to the Python executable that octoprint uses, so the command becomes: ``` /home/pi/oprint/bin/python3 /home/pi/oprint/lib/python3.7/site-packages/octoprint_enclosure/BME280.py 0x76 ``` instead of: ``` python /home/pi/oprint/lib/python3.7/site-packages/octoprint_enclosure/BME280.py 0x76 ``` Lastly, it also properly logs errors that occur in the `BME280.py` script. Tested with Octopi 0.18.0 and octoprint 1.7.0.
thijstriemstra commented 2021-11-10 02:33:36 +00:00 (Migrated from github.com)
Copy Link

ping @vitormhenrique

ping @vitormhenrique
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
documentation
duplicate
enhancement
help wanted
invalid
Missing Data
Missing necessary data to troubleshoot
 question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Gandalf
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Gandalf/OctoPrint-Enclosure#444
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?