Gandalf/OctoPrint-Enclosure
1
0
Fork 0
Code Issues 156 Pull Requests 6 Actions Packages Projects Releases 28 Wiki Activity

Create bme680.py #253

Closed
cristianku wants to merge 7 commits from master into master
pull from: master
merge into: Gandalf:master
Conversation 8 Commits 7 Files Changed 4 +515 -2040
cristianku commented 2019-08-19 10:35:11 +01:00 (Migrated from github.com)
Copy Link

additional bme680

additional bme680
cristianku (Migrated from github.com) reviewed 2019-08-19 16:12:19 +01:00
cristianku (Migrated from github.com) left a comment
Copy Link

this are my changes to implement the bme680 used to read Temperature and Humidity. It can also read the Air Quality, but this feature I have still in development, and the for the integration with your plugin, I may need your help since I need to introduce the air quality and the possibility to command filtering system from Octoprint Enclosure

this are my changes to implement the bme680 used to read Temperature and Humidity. It can also read the Air Quality, but this feature I have still in development, and the for the integration with your plugin, I may need your help since I need to introduce the air quality and the possibility to command filtering system from Octoprint Enclosure
IvanGirderboot commented 2021-01-31 21:48:19 +00:00 (Migrated from github.com)
Copy Link

Is this PR still workable? I'd like to see the 680 implemented and I'd hate to redo work that's already been done.

Is this PR still workable? I'd like to see the 680 implemented and I'd hate to redo work that's already been done.
vitormhenrique commented 2021-01-31 23:58:03 +00:00 (Migrated from github.com)
Copy Link

Is this PR still workable? I'd like to see the 680 implemented and I'd hate to redo work that's already been done.

It’s barely few lines of code to add new sensors, and if you see my latest comments i’m re writing the entire plugin on the python3 branch, making any change and PR here really worth merging, testing and releasing....

i’ll add the bme680 on the new version, but no ETA on anything....

> Is this PR still workable? I'd like to see the 680 implemented and I'd hate to redo work that's already been done. It’s barely few lines of code to add new sensors, and if you see my latest comments i’m re writing the entire plugin on the python3 branch, making any change and PR here really worth merging, testing and releasing.... i’ll add the bme680 on the new version, but no ETA on anything....
IvanGirderboot commented 2021-02-01 04:57:20 +00:00 (Migrated from github.com)
Copy Link

Good to know. I'm happy to help out on the implemention side; it would be great to expose pressure and IAQ in the GUI for the sensors that support it.

Good to know. I'm happy to help out on the implemention side; it would be great to expose pressure and IAQ in the GUI for the sensors that support it.
MarcelloTheArcane (Migrated from github.com) reviewed 2021-08-26 10:05:09 +01:00
octoprint_enclosure/BME680_AQI.py
@@ -0,0 +15,4 @@
# change the balance between accuracy and noise in
# the data.
hum_weighting = float(0.25) # so hum effect is 25% of the total air quality score
MarcelloTheArcane (Migrated from github.com) commented 2021-08-26 10:05:09 +01:00
Copy Link

Why do you use float(0.25) as opposed to just 0.25? Python will recognise a decimal as a float I think.

You can use 40.0 for hum_reference too, to make sure it is cast as a float.

Why do you use `float(0.25)` as opposed to just `0.25`? Python will recognise a decimal as a float I think. You can use `40.0` for `hum_reference` too, to make sure it is cast as a float.
vitormhenrique commented 2021-10-17 22:16:53 +01:00 (Migrated from github.com)
Copy Link

Would you mind fixing the conflicts?
I'm fixing some issues here and would like to get all PR's on master

Would you mind fixing the conflicts? I'm fixing some issues here and would like to get all PR's on master
thijstriemstra commented 2021-12-07 19:10:54 +00:00 (Migrated from github.com)
Copy Link

this can be closed (#441 was merged instead).

this can be closed (#441 was merged instead).
vitormhenrique commented 2022-01-02 21:29:36 +00:00 (Migrated from github.com)
Copy Link

Closed as it was included on another merge

Closed as it was included on another merge

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
cristianku
MarcelloTheArcane
Labels
Clear labels
bug
documentation
duplicate
enhancement
help wanted
invalid
Missing Data
Missing necessary data to troubleshoot
 question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Gandalf
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Gandalf/OctoPrint-Enclosure#253
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?